trishika / DroidUPnP

DroidUPnP is an upnp control point application for android.
GNU General Public License v3.0
150 stars 61 forks source link

subtitle support, tested with xbmc/kodi #48

Closed marcellourbani closed 6 years ago

marcellourbani commented 9 years ago

Works seamlessly in my environment (serviio-xbmc on raspberry pi, needs a recentish kodi build, mine is 13.2). it's not minimal: I could have added a single subtitle resource and two protocolinfo (as soon as you have more than a node you need that to classify them) but I thought this would be more flexible (i.e. support multiple subtitle streams). After stopping the subtitle info is lost, couldn't understand how to fix that: I reckon the issue is that cling doesn't return current position metadata, the only workaround I can think of is to store it but looks a bit too invasive. Pausing and seeking work fine.

trishika commented 8 years ago

Sorry this is old, I am digging... First indentation is a mess, please use tab. Second, I just read the code but I am not sure to understand what this is doing, perhaps some comment into the code and a real commit messege would help.