search

trishume / eyeLike

A webcam based pupil tracking implementation.
MIT License
917 stars 335 forks source link

Fix for openCV in 4.0+ #23

Closed Riroaki closed 5 years ago

Riroaki commented 5 years ago

Changes:

trishume commented 5 years ago

Thanks for doing this, I'm sure it'll help people!

Do you happen to know whether these changes are compatible with OpenCV 3.0? If so I'm comfortable merging this.

Otherwise I just checked and 4.0 is pretty new, Debian stable doesn't have it yet for example. I can leave this as an open PR though for people who want to compile on 4.0 to find though. Alternatively if you could make it compile on both that would be nice but not not necessary.

Riroaki commented 5 years ago

Thanks for doing this, I'm sure it'll help people!

Do you happen to know whether these changes are compatible with OpenCV 3.0? If so I'm comfortable merging this.

Otherwise I just checked and 4.0 is pretty new, Debian stable doesn't have it yet for example. I can leave this as an open PR though for people who want to compile on 4.0 to find though. Alternatively if you could make it compile on both that would be nice but not not necessary.

Thanks for your reply and I attempted again by recovering old codes and adding some macros for the 4.x version api 😄 And also removed the "aa" and "aaa" windows as matrix dichotomy is no longer applied. I think this would work with work with 3 and 4 versions, as I did not have 3.x version on my mac lol.