search

trishume / eyeLike

A webcam based pupil tracking implementation.
MIT License
917 stars 335 forks source link

Fix for OpenCV 3.0.0 #6

Closed SVN93 closed 8 years ago

trishume commented 8 years ago

Nice thanks, sorry I missed this for so long. I'm just fixing up my notification settings.

The non-whitespace changes in here look good. Definitely agree that crosshairs are better than circles.

Not sure how I feel about re-indenting almost the whole repository to 4 spaces instead of two. It would certainly break git blame. 4 spaces might be more standard, but I'm not sure it is worth the massive diff at this point. I also definitely don't like the 4 trailing spaces on blank lines.

I'm quite busy right now but unless you want to undo the whitespace change and then use git rebase -i to squash the commits, I might fix up the whitespace myself in a few weeks and merge this (I'll make sure not to mess up the author on the commits so you get contribution credit).

trishume commented 8 years ago

I ended up adding my own support for OpenCV 3.0 that is also backwards compatible with older versions via #if in https://github.com/trishume/eyeLike/commit/1a635a17d94feffab9ea18dc92efd3f2d70d6ea9