trisignia / mass_mandrill

mass_mandrill
MIT License
6 stars 3 forks source link

Removing api key and other minor tweaks #5

Closed hammady closed 9 years ago

hammady commented 9 years ago

Hi there, I have simplified the integration of the gem by removing the api_key configuration (now read from ENV by the official mandril-api gem). Also did some minor tweaks, please read commit messages.

strika commented 9 years ago

It looks good. Thanks.

Would you mind adding a sentence or two in the Readme that a user should export the environment variable? It might not be obvious that the gem is using mandrill-api under the hood. Thanks.

hammady commented 9 years ago

Updated.

strika commented 9 years ago

Great work! :+1: Thanks.

hammady commented 9 years ago

Thanks