search

triska / clpz

Constraint Logic Programming over Integers
https://www.metalevel.at/prolog/clpz
184 stars 15 forks source link

Copy Scryer Aug 2020 mod enhancements #32

Open jeshan opened 9 months ago

jeshan commented 9 months ago

Copies commits made by @notoria in Scryer to improve mod.

List of commits:

I have not copied the tests here. Should I? image

As usual, please review as I make mistakes some times!

UWN commented 9 months ago

Does it really make sense to copy the improvements that happened for Scryer's clpz piece-by-piece? Wouldn't it be better to take all of them in one fell swoop?

jeshan commented 9 months ago

For mod, I took all of them at once. If you meant for the whole module, then I'm not qualified to work on the clpz codebase! For future PRs, it would surely be better to copy bigger ones at a time.