tristandeleu / pytorch-meta

A collection of extensions and data-loaders for few-shot learning & meta-learning in PyTorch
https://tristandeleu.github.io/pytorch-meta/
MIT License
1.97k stars 256 forks source link

DataParallel in PytorchLightning #88

Open ajoshi80 opened 4 years ago

ajoshi80 commented 4 years ago

Thanks so much for the fix for Pytorch 1.50, It works great!

I was attempting at using it with lightning and the issue I found is this:

Line 172 in pytorch_lightning/overrides/data_parallel.py output = module.validation_step(*input, **kwargs) TypeError: validation_step() got an unexpected keyword argument 'params'

I think this may have to do with the stateless nature of torchmeta and passing params while lightning models have a validation_step() method defined. https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/overrides/data_parallel.py