tristandunn / pusher-fake

A fake Pusher server for development and testing.
https://rubygems.org/gems/pusher-fake
MIT License
173 stars 32 forks source link

clarify readme #54

Closed jtwaleson closed 6 years ago

tristandunn commented 6 years ago

Thanks for the pull request! I merged the typo fix in https://github.com/tristandunn/pusher-fake/commit/f49d48a52d711cb920c3e355f8ca24589028bdc7 and my reasons for not merging the other changes are listed below.

While mostly functional [...]

It's intended to be completely functionally. If it's missing something could you open an issue and let me know what it is? I try to stay updated on the Pusher changes, but could have missed something.

If not running in Rails [...]

This project isn't really intended to be supported outside of Ruby. While it can be, it opens up several other worlds of support that would be harder for me to debug and support. So while I don't discourage it, I don't want to encourage it and take over support for it.

Moving the binary to the test environment section.

The binary was strictly added to be part of a Docker workflow, which I don't consider a common use case since the library is meant to be used within the test environment, but I get the need to have it in Docker in certain cases.