Call `to_s` on the app_id

tristandunn / pusher-fake

A fake Pusher server for development and testing.

https://rubygems.org/gems/pusher-fake

MIT License

173 stars 32 forks source link

Call `to_s` on the app_id #55

Closed craigmcnamara closed 6 years ago

craigmcnamara commented 6 years ago

I have an old Pusher id that happens to be numeric. Setting that in my YAML config I get a very unhelpful error message from inside pusher-fake: "Bad request: no implicit conversion of Integer into String"

By calling to_s on this my old fashioned numeric id works as intended.

tristandunn commented 6 years ago

Nice catch and thanks for the PR! I added a few tests and moved the conversion to the configuration class. See https://github.com/tristandunn/pusher-fake/commit/776ea81a16f1ad5ae27f11811e2386d11556311d. I'll release a new version soon.

tristandunn commented 6 years ago

@craigmcnamara Released v1.10.0 that includes the fix. Thanks again!