search

tristandunn / pusher-fake

A fake Pusher server for development and testing.
https://rubygems.org/gems/pusher-fake
MIT License
173 stars 32 forks source link

Fix connection ID for ruby 2.7. #62

Closed mthorn closed 4 years ago

mthorn commented 4 years ago

Ruby 2.7 Object#object_id can return numbers with an odd number of decimal digits. This would lead to a bunch of connections with the same socket ID value.

tristandunn commented 4 years ago

Thanks! I started to add Ruby 2.7 support but never dug into the failures. Seems like this would have been an annoying issue to find.

Merged in https://github.com/tristandunn/pusher-fake/commit/3eb9b841ec380b0b270df53a4eef1ecb9e0a4e50. Will try to get a 2.0 release today, or this week at the latest.

tristandunn commented 4 years ago

@mthorn Took way too long to release, but it's the a big 2.0 release a little over eight years after the first release. Thanks again for the fix!