tristanhimmelman / AlamofireObjectMapper

An Alamofire extension which converts JSON response data into swift objects using ObjectMapper
MIT License
2.66k stars 474 forks source link

Cartfile in the 3.0.2 tag specifies incompatible dependency #162

Closed kalkwarf closed 7 years ago

kalkwarf commented 8 years ago

I believe the 3.0.2 tag is intended to support Swift 2.3, but one of the dependencies specified in the Cartfile is not Swift 2.3 compatible.

Instead of github "Alamofire/Alamofire" ~> 3.0.0

I think it should be github "Alamofire/Alamofire" ~> 3.5

kalkwarf commented 8 years ago

Well, now I'm confused.

The Cartfile says github "Alamofire/Alamofire" ~> 3.0.0 which gets resolved to github "Alamofire/Alamofire" "3.4.0" If I set the Cartfile to github "Alamofire/Alamofire" ~> "3.5" it resolves to github "Alamofire/Alamofire" "3.5.1"

I'm not sure why

tristanhimmelman commented 7 years ago

Sorry for the confusion. I did not handle the migration to swift 2.3 then to swift 3.0 as well as I would have liked.

Moving forward I am only actively supporting swift 3