tristanhimmelman / AlamofireObjectMapper

An Alamofire extension which converts JSON response data into swift objects using ObjectMapper
MIT License
2.66k stars 474 forks source link

Fix carthage support by removing submodules #164

Closed ehuynh closed 7 years ago

ehuynh commented 8 years ago

The submodules are causing an issue when including AlamofireObjectMapper via Carthage (not using the --use-submodules option). The issue seems to be that the submodules are being checked out by Carthage when it is cloning/fetching AlamofireObjectMapper. Because of this, the framework is being build against the commit/versions of ObjectMapper and Alamofire that the submodules points to, instead of the versions that have been resolved by Carthage. I think this is what is causing the issue with https://github.com/tristanhimmelman/AlamofireObjectMapper/issues/147.

If we remove the submodules, this would mean that when someone clones this project, they will need to either use Carthage to checkout the dependencies, or clone them manually themselves, to be able to build the project.

I'm not sure if this is the best fix, but it does get Carthage working again