search

tristanhimmelman / AlamofireObjectMapper

An Alamofire extension which converts JSON response data into swift objects using ObjectMapper
MIT License
2.66k stars 474 forks source link

Fixed build errors #271

Closed RomanPodymov closed 5 years ago

RomanPodymov commented 5 years ago

Hello. In this pull request I fixed build errors caused by the latest Alamofire v.5.0.0-beta.6. As for me we should use a pattern like s.dependency 'Alamofire', '5.0.0-beta.6' for beta versions of dependencies. That's why all responseObject functions should accept queue: DispatchQueue = .main - the same way as it is implemented here. Fixes #267, #270.

tirrorex commented 5 years ago

Related to #276 Accepting this pull request should allow the library to be updated in swift 5. Do you see other fixes to do @tristanhimmelman ? I could take the time and do a quick PR if needed.

RomanPodymov commented 5 years ago

Hello @tristanhimmelman Could you please release a new beta version of AlamofireObjectMapper with this pull request included? It will be helpful for those who want to use the latest beta Alamofire (currently it is 5.0.0-beta.6). You can also change the destination branch.