search

tristanhimmelman / AlamofireObjectMapper

An Alamofire extension which converts JSON response data into swift objects using ObjectMapper
MIT License
2.66k stars 474 forks source link

Updating podspec to swift 5 #276

Closed tirrorex closed 4 years ago

tirrorex commented 5 years ago

Hello, Since the 6.0 and master are using Alamofire 5.0 beta (which uses swift 5 since beta 4), isn't it possible to do a quick release or update master to use the last version of Alamofire ?

Currently the lib still uses swift 4.2 which prevents us from updating our library to swift 5.

RomanPodymov commented 5 years ago

Hello @tirrorex Could you please check if the issue is reproducing with AlamofireObjectMapper 6.1.0? This version works fine in Swift 5 projects.

tirrorex commented 5 years ago

Hello, @RomanPodymov i can tell you just by looking at the commits that it will not pass the lint process (some changes i made in my branch are missing). The library compiling in a project and linting it as a dependency are two separated things ;)

RomanPodymov commented 5 years ago

Hello @tirrorex What error do you get on pod spec lint?

tristanhimmelman commented 4 years ago

6.2.0 should resolve this issue