tristanhimmelman / AlamofireObjectMapper

An Alamofire extension which converts JSON response data into swift objects using ObjectMapper
MIT License
2.66k stars 476 forks source link

Alamofire 5 #301

Closed RomanPodymov closed 1 year ago

RomanPodymov commented 4 years ago

Hello. Thank you for AlamofireObjectMapper. In this pull request I replaced Alamofire 5.0.0-rc3 with Alamofire 5.

ppamorim commented 4 years ago

@tristanhimmelman Could you please review this?

ppamorim commented 4 years ago

@RomanPodymov This library is abandoned. Anyone who wants this fix, just replace your pod with:

pod 'AlamofireObjectMapper', :git => 'https://github.com/T-Pro/AlamofireObjectMapper.git', :branch => 'master'
ppamorim commented 4 years ago

@RomanPodymov You forgot to update your podspec.

RomanPodymov commented 4 years ago

@RomanPodymov You forgot to update your podspec.

Hello @ppamorim Alamofire 5.0.4 will be installed even with s.dependency 'Alamofire', '~> 5.0.0'.

ppamorim commented 4 years ago

@RomanPodymov I was getting error on my side.

RomanPodymov commented 4 years ago

@RomanPodymov I was getting error on my side.

@ppamorim What error do you get?

ppamorim commented 4 years ago

@RomanPodymov It was saying that it was using the dependency 5.0.0, even doing pod repo update and pod update. But now it's working after I sync with my branch and then with ours after. Probably it was the cache.

ozgur commented 4 years ago

Hi @tristanhimmelman Any update on getting this PR merged?

akellyak47 commented 4 years ago

@ppamorim is this library confirmed abandoned by @tristanhimmelman ?

kambala-decapitator commented 4 years ago

@RomanPodymov Alamofire 5.1 has been released, you have to fix/update your podspec

kambala-decapitator commented 4 years ago

@RomanPodymov not sure why you use "\~> 5.1.0" (locking to 5.1.x) instead of "\~> 5.1"

RomanPodymov commented 4 years ago

@RomanPodymov not sure why you use "~> 5.1.0" (locking to 5.1.x) instead of "~> 5.1"

I was not sure if Alamofire 5.0 and Alamofire 5.1 have the same public API.

borisdipner commented 2 years ago

SPM ready for object mapper and Codable AF5 https://github.com/borisdipner/AlamofireObjecter