search

tristanhimmelman / ObjectMapper

Simple JSON Object mapping written in Swift
MIT License
9.14k stars 1.03k forks source link

Fix: Could not map to optional RawRepresentable enum for ImmutableMappable #1059

Closed r-plus closed 5 years ago

r-plus commented 5 years ago

Related #1043, #1057.

This PR fixed #1057(it fixed for BaseMappable) missing part of RawRepresentable.

Test code is based on my #1058, it will be dismissed if this merge.

felipe-azevedo commented 5 years ago

I think this will fix the issue I pointed out in #1043. Looking forward for a release with this.

felipe-azevedo commented 5 years ago

I'd very much like this released asap. Thank you.

felipe-azevedo commented 5 years ago

@tristanhimmelman I also need this PR released. Thank you.

felipe-azevedo commented 5 years ago

@tristanhimmelman please merge this. The library is unusable on Swift 5 without this fix. This is preventing me from updating to Swift 5.

felipe-azevedo commented 5 years ago

@tristanhimmelman, hi. Sorry to bother again, but I've been asking for this fix for the past 2 weeks. Again, this is keeping me from updating my app.

tristanhimmelman commented 5 years ago

@felipe-azevedo my apologies for the slow review. Thank you for your contribution 🙏