tristanhimmelman / ObjectMapper

Simple JSON Object mapping written in Swift
MIT License
9.16k stars 1.03k forks source link

Update Apple Upcoming Requirements #1142

Closed selvam4274 closed 7 months ago

selvam4274 commented 8 months ago

Privacy Manifests: https://developer.apple.com/support/third-party-SDK-requirements/

App Store Connect upload requirement https://developer.apple.com/news/?id=fxu2qp7b

Why

Screenshot 2024-04-04 at 9 18 47 AM

What

Test Case

Screenshot 2024-04-04 at 11 37 50 AM Screenshot 2024-04-04 at 11 38 00 AM Screenshot 2024-04-04 at 11 38 09 AM
elmetal commented 8 months ago

Great! It seems that the empty privacy manifest might be unnecessary. What do you think?

IS PrivacyManifest.xcprivacy still required for Framework even if no privacy accessed API is used? - https://forums.developer.apple.com/forums/thread/746481?answerId=782256022#782256022

If your framework doesn't require a privacy manifest, do nothing. Avoid adding an empty privacy manifest to your framework.

selvam4274 commented 8 months ago

Great! It seems that the empty privacy manifest might be unnecessary. What do you think?

IS PrivacyManifest.xcprivacy still required for Framework even if no privacy accessed API is used? - https://forums.developer.apple.com/forums/thread/746481?answerId=782256022#782256022 If your framework doesn't require a privacy manifest, do nothing. Avoid adding an empty privacy manifest to your framework.

@elmetal Thanks for bringing this up. It's an interesting point regarding the necessity of the PrivacyManifest.xcprivacy file, especially, I referred Snapkit

listed under https://developer.apple.com/support/third-party-SDK-requirements

Screenshot 2024-04-04 at 11 19 31 PM

With empty privacy manifest

Screenshot 2024-04-04 at 11 20 05 PM

We can avoid unnecessary app rejection or the need to appeal a review by simply not adding this.