tristanhimmelman / ObjectMapper

Simple JSON Object mapping written in Swift
MIT License
9.13k stars 1.03k forks source link

Revert the original config to support old ios version #1146

Closed mvn-thanhnguyen4-dn closed 4 months ago

mvn-thanhnguyen4-dn commented 4 months ago

Why

https://github.com/tristanhimmelman/ObjectMapper/pull/1142#discussion_r1571907250

I assume "must be built with Xcode 15 for iOS 17..." does not mean we should set the deployment target to iOS 17 as it will break most existing clients of the library who still might support earlier iOS versions.

If you check https://developer.apple.com/ios/submit/ it just says "must be built with a minimum of Xcode 15 and the iOS 17 SDK." There is no limitation to the deployment target it just has to be built with Xcode 15 and the latest SDK which makes sense.

I believe we will have to revert most of the introduced limitations in this pull request.

What

Test case

Screenshot 2024-04-23 at 10 08 02 Screenshot 2024-04-23 at 10 15 05