tristanhimmelman / ObjectMapper

Simple JSON Object mapping written in Swift
MIT License
9.16k stars 1.04k forks source link

Hi there are some Error in Xcode Version 10.0 beta (10L176w) & Swift 4.x #977

Closed iusn closed 6 years ago

iusn commented 6 years ago

like this screen shot 2018-06-05 at 9 26 57 pm

asowers1 commented 6 years ago

seeing the same here

arnopoulos commented 6 years ago

I believe that this a duplicate of #975

Vadimkomis commented 6 years ago

seeing the same issue

alecdoconnor commented 6 years ago

I have created a PR at https://github.com/Hearst-DD/ObjectMapper/pull/978 to hopefully fix this issue. I noticed, after creating it, that another PR exists which has failed tests. Hopefully this produces the right results!

joshwoods commented 6 years ago

Is there any timeline to be getting a fix in for this? I would like to be moving forward using Xcode 10 to prep for iOS 12, however, this is making it so I cannot even compile our main app. Thanks in advance!

alecdoconnor commented 6 years ago

Hi Josh! Feel free to contribute to the PR to help us get closer to a working build. I believe this PR technically works, so you would be able to check the branch out directly into your project.

madaoCN commented 6 years ago

seeing the same issue

batuhangobekli-deprecated commented 6 years ago

When the update will come.I will transfer if not?

kaspermunck commented 6 years ago

The compile errors are caused by a change in Swift 4.2 described in Abolish ImplicitlyUnwrappedOptional type Swift Evolution.

I have forked the repo and fixed the compile errors, but I don't think it should be merged into master yet. @tristanhimmelman would you accept a PR into master, or could you perhaps create a swift4.2 branch that we can submit PR's against?

gcharita commented 6 years ago

There are already three PRs pending for this issue (#976, #978, #980), one of which have passed all tests.

kaspermunck commented 6 years ago

Saw that moments after posting my comment. Great to have options to choose from ;-)

gcharita commented 6 years ago

980 solved