search

tristanlatr / sre_parse36

Python 3.6 sre_parse module
GNU General Public License v3.0
0 stars 0 forks source link

Tagging of current release state? #1

Open tijuca opened 2 years ago

tijuca commented 2 years ago

Is the current state a planned release?

There is a version 1.0.0 stated within the setup.py file, is this the version that is targeted?

I'm asking because I wanted to package this library as we need these to get pydoctor updated within the archive. But to get started with an packaging a proper version information would be really nice. :-)

tristanlatr commented 2 years ago

Hi @tijuca,

Yes the current state is a stable release.

If I understand correctly, you just need me to tag this repo with version 1.0.0 ?

The version 1.0.0 is correct, I’ve created this module for the purpose of pydoctor, it should not be updated very often.

Thanks for your work updating the python-pydoctor package. We should say in the docs that pydoctor can be installed with apt.

tijuca commented 2 years ago

Thanks for your quick answer @tristanlatr !

If I understand correctly, you just need me to tag this repo with version 1.0.0 ?

Correct, just to avoid some possible version huzzle in the future as we can't decrease versions easily. The tag is all I'd like to see. :smile:

We should say in the docs that pydoctor can be installed with apt.

This is up to you if you like to do that, I know that some people have some different view on packaging Python libraries for Debian or whatever distribution. I often work within environments there I don't have free access to the internet and I depend on packaged stuff from Debian.

tristanlatr commented 2 years ago

I’ve created a tag.

Which package are you taking care of exactly? https://launchpad.net/ubuntu/+source/pydoctor? https://tracker.debian.org/pkg/pydoctor? Are there others?

tijuca commented 2 years ago

Thanks!

I've looked into the latter, Ubuntu is typically pulling in from Debian unstable.

The longer story behind sre_parse36 and pydoctor is that originally pytest-twisted is provoking some autopkgtests failing in Debian that causes automatic removal of the packages from testing.

E.g. https://tracker.debian.org/pkg/python-promise That is in the end https://bugs.debian.org/1001371, but the root of the issue is the twisted package so far I see, but as twisted is rather a bit outdated in Debian it should not only be fixed here but the package should be updated any way. To get this done it requires a newer version of pydoctor now (and this requires sre_parse36 be available). So it's a little bit complex in the end.

tristanlatr commented 2 years ago

Maybe it would make it some simple to package sre_parse36 within pydoctor?

I could publish a bugfix release that includes it for the sake of simplicity.

tijuca commented 2 years ago

That would be nice! Because it's really really "just" a small file that could be shipped within pydoctor and accessed / referenced locally, I know of no other Python library that would use sre_parse36.py. I guess it would also be worth a try to upstream your additions to sre_parse.py so all other users of SRE could participate. But I have no clue how upstream will react on such an attempt.

tristanlatr commented 2 years ago

I’ll do that tomorrow.

I guess it would also be worth a try to upstream your additions to sre_parse.py

There is no addition, it’s only the python 3.6 sre_parse module.

So, if I understand correctly, all new requirements of pydoctor must be added to the Debian archive ?

tijuca commented 2 years ago

Correct. The basic rule in Debian is that we can only build stuff with/from packages inside the archive. And there is no access to the outer world (aka Internet) while the package built. If an required package isn't already packaged, but is e.g. needed for updating some existing package to a more recent version, we need to package this first. Such an preparation goes than into the NEW queue were the FTP-Master check the new package for Debian compliance.

tristanlatr commented 2 years ago

Thanks for the info,

Ill try to avoid to many external dependency on pydoctor in the future.

The sre_parse36 module has been included in pydoctor code and a new release has been triggered.

https://github.com/twisted/pydoctor/pull/458#event-5866480189

It would be great to document the process of update Debian copy of pydoctor. This may we could contribute to that effort when there are new releases, and pydoctor could be update I the archive faster. If you have some time, could you add a new section in the contributing docs of pydoctor explaining the process to update Debian archive?

thanks

tijuca commented 2 years ago

Thanks for preparing a new point release of pydoctor, will try to work further on updating the package in Debian in the next days.

It would be great to document the process of update Debian copy of pydoctor.

You mean within that file? https://github.com/twisted/pydoctor/blob/master/docs/source/contrib.rst I can try to write up some summarize about pydoctor in Debian, but will take some more time, I can't promise currently when it would be ready for review.

tristanlatr commented 2 years ago

You mean within that file? https://github.com/twisted/pydoctor/blob/master/docs/source/contrib.rst

Yes exactly, it would be very appreciated!

Thanks