search

tristanls / dynamodb-lock-client

A general purpose distributed locking library built for AWS DynamoDB.
MIT License
50 stars 19 forks source link

Are you using this in production? #4

Closed simlu closed 6 years ago

simlu commented 6 years ago

Considering that there are no tests... Are you using this? How tested is this implementation?

tristanls commented 6 years ago

Howdy.

The FailClosed client I use extensively at a "human running a CLI" level of usage. It is integrated into CLIs that need to update an S3 Bucket Policy atomically and performs as expected (doesn't acquire lock if lock exists, acquires and releases lock in normal operation, and fails to release lock on a crash).

Perhaps @Jacob-Lynch has insights on the FailOpen client usage.

JacobLynch commented 6 years ago

Hey, I've been using this on our production lambdas since late last year when @tristanls fixed the only issue I've run into so far. In the last three months the lambdas have been called 30k+ times with no issues that I've noticed. We use it to prevent duplicate objects being created in our database.

simlu commented 6 years ago

Thank you both for the feedback!

@Jacob-Lynch We got quite similar use cases then. Our load might be significantly bigger though. Let's see how well it holds up!

simlu commented 6 years ago

Works well. Thanks for the feedback!

We'll be stress testing more down the road, but will open ticket if we run into issues.

Closing

tristanls commented 6 years ago

Thank you for circling back and letting us know! :)