search

tristen / hoverintent

:mouse: Fire mouse events when a user intends it
https://tristen.ca/hoverintent/
MIT License
331 stars 54 forks source link

Add cjs support #7

Closed olsonpm closed 9 years ago

olsonpm commented 9 years ago

Please provide 'require()' support for cjs. Personally I don't have a need for any other modules, but it would probably help others to just add umd support.

I can create a pull request if you respond to this. Otherwise I'll just publish a fork to npm.

tristen commented 9 years ago

@olsonpm a pull request would be great!

olsonpm commented 9 years ago

Awesome. I'll have one by tomorrow, not sure i'll get to it tonight.

On Tuesday, February 3, 2015, tristen notifications@github.com wrote:

@olsonpm https://github.com/olsonpm a pull request would be great!

— Reply to this email directly or view it on GitHub https://github.com/tristen/hoverintent/issues/7#issuecomment-72654039.

olsonpm commented 9 years ago

Hey so I finally finished up a couple personal projects and had time to look into this. The deal-breaking issue I realize is that you want hoverintent to be attached to the window as opposed to the jquery object. I wanted to keep this as a jquery plugin, and don't want to mess with your library's assumption of having the global context. I'll just keep a personal copy then.

Sorry for the bother! And sorry it took me so long to get back to this.