search

tristen / tablesort

:arrow_up_down: A small tablesorter in plain JavaScript
https://tristen.ca/tablesort/demo/
MIT License
1.1k stars 179 forks source link

Fix the build by fixing the (most recent) tests #191

Closed tripu closed 4 years ago

tripu commented 4 years ago

I think #181 broke the build four months ago.

It's not because phantomjs[-prebuilt] is long dead (as @tristen suspected back then), but rather a missing t.end() at the end of that new “sorts with column keys” section of tests. (What I don't understand is how it could be that “tests pass[ed] locally” :man_shrugging:)

This fixes that.

I suggest we publish 5.2.1 after merging this.

/cc @harimohanraj89

tripu commented 4 years ago

@tristen, shall I publish 5.2.1 myself, then — or do you do that?

(If you want me to do it: do you simply bump the version, create the tag, and npm publish by hand?)

tristen commented 4 years ago

👋 Apologies for the late reply. Yeah, those steps are right. It's easy for me to do: https://www.npmjs.com/package/tablesort/v/5.2.1