search

tristen / tablesort

:arrow_up_down: A small tablesorter in plain JavaScript
https://tristen.ca/tablesort/demo/
MIT License
1.1k stars 179 forks source link

Wrong version number in minified 5.3.0 #216

Closed MHLut closed 1 year ago

MHLut commented 2 years ago

See minified version 5.3.0 on unpkg, comment header on top of the file. The comment on top of the file lists the version as 5.2.1 instead of 5.3.0.

I've checked minified version 5.2.1 on unpkg, which has different file contents, which leads me to believe that the 5.3.0 has the wrong version comment on top of the file.

Related commit: https://github.com/tristen/tablesort/commit/4fec8c3c383d61735764ca194d4fb00043456312

tripu commented 2 years ago

(Not about Unpkg specifically; the release 5.3.0 is wrong here on GH, too.)

I see. For some reason, 4fec8c3c383d61735764ca194d4fb00043456312 did not set the right version in the headers of all the files under dist/. It's weird, because the date was set correctly, and also because I just ran npm run build on my local environment, and Grunt interpolated and updated those strings as expected (the version, too).

I was tempted to open a PR to fix this, but if we merge that, either we will bump the version just for this mostly irrelevant change, or we republish the same version to fix those comments… both options seem wrong to me. I think we can live with the misleading comment blocks until a new version is released. So I would close this.

Thoughts from the other maintainers?