Fix burst-search with L parameter

tritemio / FRETBursts

Burst analysis software for smFRET. **Moved to OpenSMFS organization**

https://github.com/OpenSMFS/FRETBursts

GNU General Public License v2.0

16 stars 17 forks source link

Fix burst-search with L parameter #57

Closed chungjjang80 closed 7 years ago

chungjjang80 commented 7 years ago

FRETBursts is ignoring the L parameter during burst search.

In this PR, burstsearch.py and burstsearch_c.pyx were modified to allow performing burst-search with the threshold L in python and cython.

tritemio commented 7 years ago

Thanks @chungjjang80! I fixed the indentation in the cython file, for the rest it look good. If the CI tests pass I'll merge it as is.

tritemio commented 7 years ago

I add tests for different L values and found a little inconsistency between the cython and python version happening when there is a burst at the very end of the timestamps array. Now is fixed. Merging.