search

tritemio / pybroom

pybroom, the python's broom to tidy up messy fit results!
http://pybroom.readthedocs.io/
MIT License
14 stars 5 forks source link

WIP: Refactor #6

Open has2k1 opened 7 years ago

has2k1 commented 7 years ago

This PR does the refactoring necessary for #5. Still to do are:

The documentation should have a table for each supported package. The rows in the table should be entries for a supported Model and 3 added rows for each of tidy function to indicate support for that function.

With pytest, there should be a way to define a base test class that has test methods, where the tests subclass the base-class and create result objects that get automatically tested.

has2k1 commented 7 years ago

@tritemio, can you enable travis for this repo.

Also, there is commented out code for versioneer. Any reasons why it did not work out?

tritemio commented 7 years ago

@has2k1, great! It looks good at first glance. I enabled Travis. Regarding versioneer, I don't remember, maybe I didn't want to add it because its size was much larger than the entire pybroom.py. Now, it makes sense to enable it anyway.

has2k1 commented 7 years ago

@tritemio, I've made a small API change in the last commit.

About a decision in that commit, are automatic parameter names p0, p1, p2, ... pn a surprise to the user? I think I have seen names as such, but I do not recall where.