search

tritiumdev / cereal-ocpp2

C/C++ cereal interface generator for OCPP 2.0 JSON schemas
GNU Lesser General Public License v3.0
16 stars 7 forks source link

Get a barebones version of workable code with a single example that c… #3

Closed wolfwoolford closed 5 years ago

wolfwoolford commented 5 years ago

…ompiles, to kick things off

wolfwoolford commented 5 years ago

@ncoghlan I'm not sure of the etiquette here.. I assigned to you is that how you want to proceed or please advise otherwise.

ncoghlan commented 5 years ago

@wolfwoolford I'm happy for you to merge your own changes directly (that's why I sent you a contributor invite).

At the moment, transferring code from here to the internal build tree is manual, and I suspect it will likely stay that way in the future (i.e. the part we'll actually use from the GitHub repo is the header file generator, not the example header files).

wolfwoolford commented 5 years ago

Ok Nick, thanks - I'm a bit new to this open source development model I'm following your lead. I was planning on resolving the DateTime issue next - the stuff I have pushed treats a DateTime as a string - this as a stop-gap pending the proper DateTime implementation. I'm pretty sure you guys have an implementation for 1.6 already, but I'm happy just to give it a fresh go and see how it turns out unless i hear loud objections :)

ncoghlan commented 5 years ago

Any objections we might end up having would be in the form of a PR that we'd ask you to take a look at :)

For the initial prototype, I just stuck in a manual string -> datetime reformatting call, but I agree it would be much nicer to deal with it as part of the code generator.

wolfwoolford commented 5 years ago

:)

fyi I've built some code to handle rfc3339 formatted time strings and the latest push uses it. It might be useful to you. I'd like to get some unit tests in, to verify it's good, but my interactive testing of the code told me it looked pretty good.

There a few little things I want to make more consistent, like commenting. I've got a TODO list in there that represents my general thinking fyi. Maybe I should turn it into issues?

I'm assuming my pushing is ok. Let me know at anytime if you think I push something that should go in branch first. :)