search

tritiumdev / cereal-ocpp2

C/C++ cereal interface generator for OCPP 2.0 JSON schemas
GNU Lesser General Public License v3.0
16 stars 7 forks source link

enable unit testing using Travis CI #5

Open wolfwoolford opened 5 years ago

wolfwoolford commented 5 years ago

the rfc3339 time_point and associated parsing code needs some unit tests.

ncoghlan commented 5 years ago

I've enabled Travis CI access for this repo, so it should be straightforward to add a .travis.yaml file to get unit tests running prior to merging PRs. At that point, the temptation to push directly should be reduced, since even those of us with that access will still want to make a PR to let the CI run first :)

Since the easiest way to get ct-cake installed is via pip, it will probably make sense to configure Travis as a Python project rather than as a C++ one: https://docs.travis-ci.com/user/languages/python/

Then what we would need to do is:

The base environment should probably be xenial (Ubuntu 16.04), since that's based on Debian 9: https://askubuntu.com/questions/445487/what-debian-version-are-the-different-ubuntu-versions-based-on

The version of Python used would be 3.5, since that's the system Python version in Debian 9.

wolfwoolford commented 5 years ago

Sounds fantastic. I'll try to add a unit test or two Thursday evening and at the same time I'll see what I can do about making the Travis stuff work.

wolfwoolford commented 5 years ago

I have pushed a set of unit tests for the rfc3339 stuff :) I'll start looking at Travis CI next, see if we can get it working