search

triton-inference-server / client

Triton Python, C++ and Java client libraries, and GRPC-generated client examples for go, java and scala.
BSD 3-Clause "New" or "Revised" License
527 stars 225 forks source link

Fixed file path for plot generation #624

Closed debermudez closed 2 months ago

debermudez commented 2 months ago

Fixed a rename that was missed Updated the artifact directory check to remove an edge case where the artifact directory is already created but the plots subdirectory was not. Now all directories are created but plots are only generated when the flag is given.

dyastremsky commented 2 months ago

Great work!

Could you update the title to something like "Fixed file path for plot generation"?

Could you also make this more specific to highlight the work done: Updated the artifact directory check to be more ergonomic?

debermudez commented 2 months ago

Great work!

Could you update the title to something like "Fixed file path for plot generation"?

Could you also make this more specific to highlight the work done: Updated the artifact directory check to be more ergonomic?

@dyastremsky updated the title and explanation. Let me know if you would prefer something even more explicit. Happy to update it to make sure it is clear and traceable.