search

triton-inference-server / fil_backend

FIL backend for the Triton Inference Server
Apache License 2.0
68 stars 35 forks source link

Provide support for categorical variables in optimized CPU inference #229

Closed wphicks closed 2 years ago

wphicks commented 2 years ago

Resolve #207

wphicks commented 2 years ago

I see a fair bit of duplicated code in simple_tree and lookup_tree

I agree 100%. Template metaprogramming resolves it fairly cleanly, but as I started to do it, I realized that there is an even nicer way we can set this up with a more significant refactor. I decided to save that for a separate PR to get categorical in now, and then I'll follow up with something that should clean up the whole codebase a fair amount. Seem all right to you?