triton-inference-server / fil_backend

FIL backend for the Triton Inference Server
Apache License 2.0
67 stars 35 forks source link

Update conda cmake version #284

Closed kthui closed 1 year ago

wphicks commented 1 year ago

Fix for the root cause of this issue is here. I've solicited review and should be able to merge as soon as it passes CI.

wphicks commented 1 year ago

Root cause fix has been merged. If you want to tweak the dependency specification and merge the latest changes from main, we can get this merged for 22.10 so we don't have to worry about it for 22.11

jbkyang-nvi commented 1 year ago

~@wphicks fyi it seems like the CI is not fixed with your change for some reason. Lets merge this to get the Triton CI working~

Too early I jumped the gun. The test passed

wphicks commented 1 year ago

@jbkyang-nvi Moved discussion offline for faster iteration

wphicks commented 1 year ago

@kthui Where possible, if we could avoid force pushes, it would be preferable. Doing so ensures that CI executes correctly without an additional manual step.