search

triton-inference-server / pytriton

PyTriton is a Flask/FastAPI-like interface that simplifies Triton's deployment in Python environments.
https://triton-inference-server.github.io/pytriton/
Apache License 2.0
687 stars 45 forks source link

disallow use of numpy 2 for now #78

Closed catwell closed 2 weeks ago

catwell commented 2 weeks ago

NumPy 2 has been released last week. It has several breaking changes.

Currently pytriton is not compatible with NumPy 2. If it is installed, all request input is garbled. It should be explicitly disallowed until it is properly supported.

piotrm-nvidia commented 2 weeks ago

Thank you for bringing this issue to our attention. We appreciate your effort in identifying the incompatibility with NumPy 2 in pytriton.

However, before I can accept your pull request, I need you to sign the Contributor License Agreement (CLA) and send it to triton-cla@nvidia.com. The CLA is available for download here: https://github.com/triton-inference-server/server/blob/main/Triton-CCLA-v1.pdf

You can find more details about contributing in our guide: https://github.com/triton-inference-server/pytriton/blob/main/CONTRIBUTING.md

catwell commented 2 weeks ago

I have already signed the CLA :) see #49

piotrm-nvidia commented 2 weeks ago

I'm sorry for confusion. Let's merge PR at master. I will run internal CI today so release will be ready soon.

piotrm-nvidia commented 2 weeks ago

@catwell, release v0.5.8 includes your PR.

catwell commented 2 weeks ago

Thank you!