add --version info option to tritonserver

mirekphd commented 1 year ago

Is your feature request related to a problem? Please describe. No command line argument can currently cause tritonserver binary to display version info and exit (without actually starting the server). This prevents us from running the usual version checks in our CICD pipelines (that would load the program to display version, not just list contents of some text file, which does not test that the binary is built properly).

Describe the solution you'd like tritonserver --version should display version number (major.minor.build) and exit.

Describe alternatives you've considered I inspected tritonserver --help and also tried the usual options (should they be undocumented in Help):

* tritonserver version
* tritonserver --version
* tritonserver -v

krishung5 commented 1 year ago

@GuanLuo Would this be something we'd like to add to our roadmap?

mirekphd commented 1 year ago

The same problem affects the Triton client as well. To reproduce:

$ docker run --rm -it --name python3.9 python:3.9 bash -c "pip install tritonclient; python -c \"import tritonclient; print(tritonclient.__version__)\" "
Collecting tritonclient
  Downloading tritonclient-2.30.0-py3-none-manylinux1_x86_64.whl (11.7 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.7/11.7 MB 47.6 MB/s eta 0:00:00
Collecting python-rapidjson>=0.9.1
  Downloading python_rapidjson-1.9-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.6 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.6/1.6 MB 26.3 MB/s eta 0:00:00
Collecting numpy>=1.19.1
  Downloading numpy-1.24.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (17.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 17.3/17.3 MB 31.6 MB/s eta 0:00:00
Installing collected packages: python-rapidjson, numpy, tritonclient
Successfully installed numpy-1.24.2 python-rapidjson-1.9 tritonclient-2.30.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
WARNING: You are using pip version 22.0.4; however, version 23.0.1 is available.
You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: module 'tritonclient' has no attribute '__version__'

triton-inference-server / server

add --version info option to tritonserver #5393