Remove custom handling of templates/ folder in pyproject.toml
Rename some files for clarity/consistency
Pip install issue (FIXED)
## Troubleshooting notes:
---
Received new warning on building wheel after @fpetrini15 moved trtllm template folder location. Need to understand why:
```
rmccormick@ced35d0-lcedt:~/triton/cli/triton_cli$ hatch build
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── sdist ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
dist/triton_cli-0.0.2.tar.gz
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── wheel ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
/usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/postprocessing/config.pbtxt'
return self._open_to_write(zinfo, force_zip64=force_zip64)
/usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/postprocessing/1/model.py'
return self._open_to_write(zinfo, force_zip64=force_zip64)
/usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/preprocessing/config.pbtxt'
return self._open_to_write(zinfo, force_zip64=force_zip64)
/usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/preprocessing/1/model.py'
return self._open_to_write(zinfo, force_zip64=force_zip64)
/usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/tensorrt_llm/config.pbtxt'
return self._open_to_write(zinfo, force_zip64=force_zip64)
/usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/tensorrt_llm/1/.gitkeep'
return self._open_to_write(zinfo, force_zip64=force_zip64)
/usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/tensorrt_llm_bls/config.pbtxt'
return self._open_to_write(zinfo, force_zip64=force_zip64)
/usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/tensorrt_llm_bls/1/model.py'
return self._open_to_write(zinfo, force_zip64=force_zip64)
dist/triton_cli-0.0.2-py3-none-any.whl
```
Fails to install with:
```
ERROR: Error while checking for conflicts. Please file an issue on pip's issue tracker: https://github.com/pypa/pip/issues/new
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/pip/_internal/commands/install.py", line 529, in _determine_conflicts
return check_install_conflicts(to_install)
File "/usr/lib/python3/dist-packages/pip/_internal/operations/check.py", line 103, in check_install_conflicts
would_be_installed = _simulate_installation_of(to_install, package_set)
File "/usr/lib/python3/dist-packages/pip/_internal/operations/check.py", line 126, in _simulate_installation_of
dist = abstract_dist.get_metadata_distribution()
File "/usr/lib/python3/dist-packages/pip/_internal/distributions/wheel.py", line 26, in get_metadata_distribution
return get_wheel_distribution(wheel, canonicalize_name(self.req.name))
File "/usr/lib/python3/dist-packages/pip/_internal/metadata/__init__.py", line 62, in get_wheel_distribution
return Distribution.from_wheel(wheel, canonical_name)
File "/usr/lib/python3/dist-packages/pip/_internal/metadata/pkg_resources.py", line 105, in from_wheel
with wheel.as_zipfile() as zf:
File "/usr/lib/python3/dist-packages/pip/_internal/metadata/base.py", line 537, in as_zipfile
return zipfile.ZipFile(self.location, allowZip64=True)
File "/usr/lib/python3.10/zipfile.py", line 1251, in __init__
self.fp = io.open(file, filemode)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-unpack-zew5tas2/triton_cli-0.0.2-py3-none-any.whl'
Installing collected packages: triton_cli
ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/tmp/pip-unpack-zew5tas2/triton_cli-0.0.2-py3-none-any.whl'
```
## Solution
Remove template folder logic in `pyproject.toml`, as it seems to work by default after being moved into `src/` directory along with other contents.
templates/
folder inpyproject.toml
Pip install issue (FIXED)
## Troubleshooting notes: --- Received new warning on building wheel after @fpetrini15 moved trtllm template folder location. Need to understand why: ``` rmccormick@ced35d0-lcedt:~/triton/cli/triton_cli$ hatch build ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── sdist ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── dist/triton_cli-0.0.2.tar.gz ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── wheel ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── /usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/postprocessing/config.pbtxt' return self._open_to_write(zinfo, force_zip64=force_zip64) /usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/postprocessing/1/model.py' return self._open_to_write(zinfo, force_zip64=force_zip64) /usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/preprocessing/config.pbtxt' return self._open_to_write(zinfo, force_zip64=force_zip64) /usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/preprocessing/1/model.py' return self._open_to_write(zinfo, force_zip64=force_zip64) /usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/tensorrt_llm/config.pbtxt' return self._open_to_write(zinfo, force_zip64=force_zip64) /usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/tensorrt_llm/1/.gitkeep' return self._open_to_write(zinfo, force_zip64=force_zip64) /usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/tensorrt_llm_bls/config.pbtxt' return self._open_to_write(zinfo, force_zip64=force_zip64) /usr/lib/python3.10/zipfile.py:1519: UserWarning: Duplicate name: 'triton_cli/templates/trtllm/tensorrt_llm_bls/1/model.py' return self._open_to_write(zinfo, force_zip64=force_zip64) dist/triton_cli-0.0.2-py3-none-any.whl ``` Fails to install with: ``` ERROR: Error while checking for conflicts. Please file an issue on pip's issue tracker: https://github.com/pypa/pip/issues/new Traceback (most recent call last): File "/usr/lib/python3/dist-packages/pip/_internal/commands/install.py", line 529, in _determine_conflicts return check_install_conflicts(to_install) File "/usr/lib/python3/dist-packages/pip/_internal/operations/check.py", line 103, in check_install_conflicts would_be_installed = _simulate_installation_of(to_install, package_set) File "/usr/lib/python3/dist-packages/pip/_internal/operations/check.py", line 126, in _simulate_installation_of dist = abstract_dist.get_metadata_distribution() File "/usr/lib/python3/dist-packages/pip/_internal/distributions/wheel.py", line 26, in get_metadata_distribution return get_wheel_distribution(wheel, canonicalize_name(self.req.name)) File "/usr/lib/python3/dist-packages/pip/_internal/metadata/__init__.py", line 62, in get_wheel_distribution return Distribution.from_wheel(wheel, canonical_name) File "/usr/lib/python3/dist-packages/pip/_internal/metadata/pkg_resources.py", line 105, in from_wheel with wheel.as_zipfile() as zf: File "/usr/lib/python3/dist-packages/pip/_internal/metadata/base.py", line 537, in as_zipfile return zipfile.ZipFile(self.location, allowZip64=True) File "/usr/lib/python3.10/zipfile.py", line 1251, in __init__ self.fp = io.open(file, filemode) FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-unpack-zew5tas2/triton_cli-0.0.2-py3-none-any.whl' Installing collected packages: triton_cli ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/tmp/pip-unpack-zew5tas2/triton_cli-0.0.2-py3-none-any.whl' ``` ## Solution Remove template folder logic in `pyproject.toml`, as it seems to work by default after being moved into `src/` directory along with other contents.