triton-inference-server / triton_cli

Triton CLI is an open source command line interface that enables users to create, deploy, and profile models served by the Triton Inference Server.
48 stars 2 forks source link

test: Unit Tests for `triton {metrics, config, status}` #66

Closed KrishnanPrash closed 4 months ago

KrishnanPrash commented 4 months ago

This PR is raised to address Jira Ticket [DLIS-6264].

Unit tests have been added primarily within triton_cli/tests/test_cli.py for triton metrics, triton config, and triton status.

Brief overview of the tests: For metrics:

For config:

For status:

Secondary Changes that were made while implementing the tests:

  1. Adding grpcio>=1.64.0 to pyproject.toml.
  2. Standardizing JSON outputs returned by triton_cli: Triton commands were previously returning keys in single quotes and boolean values as {True, False} instead of {true,false}. This leads to errors when the output is attempted to be parsed as a json.
rmccorm4 commented 4 months ago

Nice job merging your first PR already! :rocket: