search

triton-lang / triton

Development repository for the Triton language and compiler
https://triton-lang.org/
MIT License
13.5k stars 1.67k forks source link

https://github.com/triton-lang/triton/pull/4222 not included in triton 3.1 #5188

Closed goldhuang closed 6 days ago

goldhuang commented 6 days ago

Hello, I have a question about https://github.com/triton-lang/triton/pull/4222. It's needed by torchao. But it's not included in triton 3.1 while pytorch 2.5 has a dependency on triton 3.1.0.

Should I cherry-pick that commit and build from source code? (Would that work? Should I pick more changes?) If yes, which one is the triton 3.1.0 release branch? Or should I use latest main branch of triton instead? Thanks!

peterbell10 commented 6 days ago

Using main is unlikely to work as PyTorch uses internal triton implementation details that aren't stable across versions. Cherry-picking the fix is your best bet, but we can't really advise on what other changes you'd need.

You could also try a nightly build of pytorch which may use a newer triton version.