search

triton-lang / triton

Development repository for the Triton language and compiler
https://triton-lang.org/
MIT License
13.5k stars 1.67k forks source link

[MXFP] Fix packing for mxfp4 type #5197

Closed ThomasRaoux closed 5 days ago

ThomasRaoux commented 5 days ago

When packing we should have element 0 in the lower bits, until this PR it was in higher bits.

ThomasRaoux commented 5 days ago

These changes are not correct. See that the ops that we do on these numbers have a shift. A correct way of doing it would be to sap x0 and x1 in tl.interleave and when pushing them back.

fix the formulas