feat: input component - Githubissues

tritonJS826 / masters-way

6 stars 25 forks source link

feat: input component #66

Closed dedushkaalex closed 8 months ago

dedushkaalex commented 9 months ago

🧑‍⚖️ Pull Request Naming Convention

Title should follow Conventional Commits
Do not put WIP in title. Use Draft PR functionality
[x] I followed naming convention rules

🤔 This is a ... What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 🧑‍💻 Refactor
[x] 🎨 Style
[ ] 🔥 Performance Improvements
[ ] 📝 Documentation Update
[x] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

💡 Background and solution

Added tests?

[x] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[x] 🙅 no documentation needed

Self Check before Merge

⚠️ Please check all items below before review. ⚠️

[x] Documentation is updated/provided or not needed
[x] Changes are tested locally

tritonJS826 commented 9 months ago

Looks nice) thanks)

tritonJS826 commented 9 months ago

BTW we added storybook to the project, could you add story for input component, please?

dedushkaalex commented 8 months ago

Fixed everything