search

tritonJS826 / masters-way

6 stars 25 forks source link

All ways page_table view mode: some ways with progress '0%_____0/0' has 'Completed' status, others - 'In progress' #752

Closed EkaterinaSokolova-V closed 3 weeks ago

EkaterinaSokolova-V commented 1 month ago

Steps to reproduce

  1. Open All ways page: https://mastersway.netlify.app/ways
  2. Switch to table view mode.
  3. Compare list of 'Completed' ways with 'In progress'.

Actual result

Some ways with progress '0%0/0' or '0%0/N' (N > 0) have 'Completed' status.

Expected result

All ways with progress '0%0/0' or '0%0/N' (N > 0) have 'In progress' status.

Additional context

Image

Ekaterina1994 commented 1 month ago

This error happen after migrate data (connected with wrong copy metrics in copied ways). Before migration way was Completed, but after migration metrics was deleted but status wayCompleted didnot changed. @tritonJS826 How will be better to correct this? We can add crutch to the front or better to change datas in database?

tritonJS826 commented 1 month ago

Better to fix it on the database

tritonJS826 commented 1 month ago

I checked and I see that way is not become completed if all metrics marked as finished. @Ekaterina1994 Why?

Ekaterina1994 commented 4 weeks ago

Need to add on backend

tritonJS826 commented 3 weeks ago

For now status recalculated after any metric change. Hope it is enoug