tritonmc / Triton

Translate your server! Sends the same message in different languages... Hooks into all plugins!
https://triton.rexcantor64.com
GNU General Public License v3.0
85 stars 32 forks source link

Triton incompatibility with BetonQuest #160

Open DeonHNT opened 2 years ago

DeonHNT commented 2 years ago

Describe the bug Using Triton plugin with Beton Quest with certain (default) setting causes no chat display.

To Reproduce Requirement: BetonQuest 1.12.7, Triton -> BetonQuest Setting: display_chat_after_conversation: 'true' -> Create an iteractable NPC with Beton Quest -> Start a conversation

Expected behavior After interacting with any NPC or started a conversation, a conversation panel should display (Interactable Chat)

Screenshots 2022-01-01_15 03 28

(Picture shows expected output) -> With Triton active, the interactive chat doesn't display until the player exit conversation mode.

Server information (please complete the following information):

Additional context There are no error in the server console, Current workaround is to allow chat to be displayed during a conversation. [display_chat_after_conversation: 'false'] I also post the issue on BetonQuest github: https://github.com/BetonQuest/BetonQuest/issues/1700

diogotcorreia commented 2 years ago

Hello! Sorry for taking so long. Could you please give more detailed instructions on how to create an NPC with Beton Quest so I can more quickly look into this? More specifically, these two points:

-> Create an iteractable NPC with Beton Quest -> Start a conversation

PystoyPlayer commented 2 years ago

Hello! Sorry for taking so long. Could you please give more detailed instructions on how to create an NPC with Beton Quest so I can more quickly look into this? More specifically, these two points:

-> Create an iteractable NPC with Beton Quest -> Start a conversation

You can just use citizens and create a NPC with /npc create Innkeeper then restart the server and click NPC. With BetonQuest you could choose phrases in an intractable conversation panel, but with Triton it shows only after player click SHIFT button to leave the conversation. My English may be bad cause that's not my native language but ask me if you want. P.s.: Same problem

PystoyPlayer commented 2 years ago

@diogotcorreia Please fix the incompatibility 🙏 That’s so important and big problem…

diogotcorreia commented 2 years ago

Hi After taking a look at this, I'm sorry to say that it isn't fixable right now due to the way Triton handles chat translation: it strips all the unnecessary color coding, but BetonQuest uses that as a filter. I hadn't given much attention to this issue earlier because I was almost sure it would be the case, from what I've read from BetonQuest's developers, but now I've confirmed it. However, Triton v4.0.0 will bring many improvements, one of which will fix this issue (as long as you don't translate any messages from BetonQuest; use their translation system instead).

Unfortunately the only solution from my side is to wait. Hopefully Triton v4.0.0 will be ready this summer!

In the mean time, take a look at the suggested fix from BetonQuest's developers, as commented in the referenced issue: https://github.com/BetonQuest/BetonQuest/issues/1700#issuecomment-1003693503

I'll keep this open, since it will be fixed in the future.

PystoyPlayer commented 2 years ago

Thank you so much!

PystoyPlayer commented 2 years ago

Hey! How is it going ? You said Triton v4.0.0 will be ready this summer, but today is the 27th of August already...

diogotcorreia commented 2 years ago

@PystoyPlayer Hi A beta version, to be released on Discord, will be published in the next week or two! Stay tuned

diogotcorreia commented 2 years ago

This has been fixed on #230, but I'll keep it open since the current state of 4.0.0 does not work correctly on Spigot yet. Follow the Triton v4 thread on Discord for more information.

I'll close this issue once Triton v4 is usable on Spigot

PystoyPlayer commented 2 years ago

@PystoyPlayer Hi A beta version, to be released on Discord, will be published in the next week or two! Stay tuned

Yey!

PystoyPlayer commented 11 months ago

2 years later

diogotcorreia commented 11 months ago

It has been possible to use the V4 beta for a while, which fixes this issue. The full release is scheduled to be out before the end of the year. Sorry for the delay 😅