tritonmc / Triton

Translate your server! Sends the same message in different languages... Hooks into all plugins!
https://triton.rexcantor64.com
GNU General Public License v3.0
85 stars 34 forks source link

Add EcoEnchants translation support (not lore) #290

Open roggy666 opened 1 year ago

roggy666 commented 1 year ago

Describe the Feature

I really need the ability to translate enchantments, in my case this is EcoEnchants, where enchantments are not lore

diogotcorreia commented 1 year ago

This is going to be pretty difficult to implement: EcoEnchants is hooking into the netty pipeline as well, but it's doing so after ProtocolLib, which means Triton can't detect its lores. I'll have to investigate if there's any workaround. Additionally, Triton v3 would completely obliterate some markers eco puts into the lores (i.e. §z). This won't be an issue on Triton v4.

Here's some implementation details that I found while investigating:

I'll move this to the v4 backlog, but even then this won't be easy and might require some custom code specifically for eco.

mani1232 commented 1 year ago

Lore too need support, %triton_lang% work but showing in default lang, [lang][/lang] dont work