search

tritonuas / obcpp

The code for the Onboard Computer, now written in C++.
GNU Affero General Public License v3.0
7 stars 0 forks source link

LUCID Camera Client #159

Closed atar13 closed 1 month ago

atar13 commented 2 months ago

Closes #29

atar13 commented 1 month ago

This PR is ready for review. It ended up touching a lot of files across the project so those reviewing can focus on files in include/camera and src/camera.

I can't figure out why the unit tests are failing. It seems to not be able to find the LucidCamera declaration. It's defined in include/camera/lucid.hpp but is behind a #ifdef that is set in the deps/arena.cmake file if Arena SDK is installed. I'll do some more digging but you can run ninja test and ninja obcpp to verify that everything is compiling correctly.

atar13 commented 1 month ago

I think the tests are failing however? Looks like a compile error with creating a lucid camera so maybe a test is out of date. So once we fix that and verify still works on the jetson I think we should be good

Yeah that's what this comment was about. I'll try to figure it out:

https://github.com/tritonuas/obcpp/pull/159#issuecomment-2097590894

Tyler-Lentz commented 1 month ago

I think the tests are failing however? Looks like a compile error with creating a lucid camera so maybe a test is out of date. So once we fix that and verify still works on the jetson I think we should be good

Yeah that's what this comment was about. I'll try to figure it out:

#159 (comment)

oh sorry i didn't see that

atar13 commented 1 month ago

Tests are passing now after some shenanigans with GitHub actions not detecting the environment variable for the ArenaSDK location set in the Docker image.