trivago / Heimdallr.swift

Easy to use OAuth 2 library for iOS, written in Swift.
Apache License 2.0
639 stars 86 forks source link

Use OHHTTPStubs instead of aerogear-ios-httpstub #47

Closed tibr closed 9 years ago

tibr commented 9 years ago

Closes #45

Unfortunately OHHTTPStubs has not released a formal version in a while so I used master.

bckr commented 9 years ago

Wouldn't it be a bit saver to pin the dependency directly to the commit we need instead of master?

tibr commented 9 years ago

The exact commit is referenced in the Carthage.resolved file: github "AliSoftware/OHHTTPStubs" "8f0f04866a2ffa1309527dd228151bba68b7fbae"

I think that when running carthage bootstrap that commit should be used automatically.

bckr commented 9 years ago

Ah, I see! :+1:

tibr commented 9 years ago

4e257bd1fe53ec8606ebcadeb5e65b83a8599311 now references the recently released version 3.1.11

tibr commented 9 years ago

52e71eb55aa16d3477b7040e6690880920b9b85e pins the exact commit just to be sure.