search

trivago / Heimdallr.swift

Easy to use OAuth 2 library for iOS, written in Swift.
Apache License 2.0
639 stars 86 forks source link

Externalize parsing of access token response #79

Closed poislagarde closed 8 years ago

poislagarde commented 8 years ago

Closes #76

bckr commented 8 years ago

@poislagarde Thank you very much for the quick pull request 🎉

At a first glance I would say that this seams like a good approach of externalising the access token parsing. I've made a few notes on code that might need a bit of fine tuning. Maybe one of the other team members want to have a look at this as well.

poislagarde commented 8 years ago

Hey @bckr, I answered to your notes. Let me know if you want me to make those changes or not. Thanks!

poislagarde commented 8 years ago

Sorry for the delay. I pushed and squashed the changes we talked about. Let me know if you need me to change something else.

bckr commented 8 years ago

@poislagarde Nice work! I think we can merge this 🚀