search

trivago / Heimdallr.swift

Easy to use OAuth 2 library for iOS, written in Swift.
Apache License 2.0
639 stars 86 forks source link

Remove Argo? #90

Closed marcelofabri closed 8 years ago

marcelofabri commented 8 years ago

Hi there!

I'm currently adding Heimdallr to our project and we already use another mapping framework. Since dynamic frameworks add a considerable overhead when loading, I was think if it was possible to remove Argo as dependency here.

My main motivation is that the models seem to be simple enough to parse them manually instead and it would keep the library simpler, avoiding:

  1. The overhead of another dynamic framework
  2. Caring about if Argo updated to Swift X.Y
  3. Potential conflicts between the Argo version used by this project and the user's project

This shouldn't even be a breaking change, since it's just an implementation detail.

I don't know the history, but it seems that on #16, everyone agreed that dependencies were fine, but https://github.com/trivago/Heimdallr.swift/commit/2be58cbe3d78903c282532ff0db8809a51db35e6 removed KeychainAccess in favor of a custom Keychain wrapper.

If response is positive to this issue, I'm willing to work on this and open a PR.

Thanks!

hffmnn commented 8 years ago

Great Idea!

I think you are absolutely right and give this definitely a 👍!

Thanks a lot for your effort!