search

trivago / cluecumber

Clear and concise reporting for the Cucumber BDD JSON format.
https://www.softwaretester.blog
Apache License 2.0
271 stars 88 forks source link

Make attachments collapsed by default with a button to show/hide. #279

Closed beirtipol closed 2 years ago

beirtipol commented 2 years ago

This addresses https://github.com/trivago/cluecumber-report-plugin/issues/227

Tested on a report containing an image and a large Thread Dump text attachment.

beirtipol commented 2 years ago

I needed an 'id' that was compatible with html and thought the hashcode of the 'attachment' object would be most useful in case the user had not set the attachment name/filename etc. so that it could still function.

bischoffdev commented 2 years ago

I am currently working on a separate feature. After that I will review your PR.

bischoffdev commented 2 years ago

I added the feature. Will be released tomorrow.

beirtipol commented 2 years ago

Thanks, I might submit another when I get time. The step detail can sometimes contain a throwabke with a lot of info. Am thinking to add a "show more" button if there are more than 10 lines.

On Mon, Jan 17, 2022, 17:11 Benjamin Bischoff @.***> wrote:

I added the feature. Will be released tomorrow.

— Reply to this email directly, view it on GitHub https://github.com/trivago/cluecumber-report-plugin/pull/279#issuecomment-1014747376, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJQO3DXA2T4IKUYZUQ3R4LUWREVXANCNFSM5L7MSTUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>