trivago / gollum

An n:m message multiplexer written in Go
http://gollum.readthedocs.org/en/latest/
Apache License 2.0
940 stars 74 forks source link

Consumer.socket cleanup #219

Closed arnecls closed 6 years ago

arnecls commented 6 years ago

The purpose of this pull request

Clean up the codebase for consumer.socket. This also fixes a bug where gollum would hang during shutdown while trying to open a new connection. In addition to this a lot more debug output has been added and all errors are properly passed to logrus.

There are a few breaking changes on the configuration that require a mention:

Config to verify

SocketUdp:
    Type: consumer.Socket
    Streams: data
    Address: udp://127.0.0.1:5880

SocketTcp:
    Type: consumer.Socket
    Streams: data
    Address: tcp://127.0.0.1:5881

SocketTcpAck:
    Type: consumer.Socket
    Streams: data
    Address: tcp://127.0.0.1:5882
    Acknowledge: ACK

SocketUDS:
    Type: consumer.Socket
    Streams: data
    Address: unix:///tmp/integration.socket

ConsoleOut:
    Type: producer.Console
    Streams: data
    Modulators:
        - format.Envelope

Checklist

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 71.371% when pulling 7c5bf88ed0dee89737c03ec6ba9335f92e479c75 on fix/consumer.socket into 6f5e205b748f9ec9acedd6fb38d1a39329f5241d on master.