Switch metrics from tgo to go-metrics

trivago / gollum

An n:m message multiplexer written in Go

http://gollum.readthedocs.org/en/latest/

Apache License 2.0

940 stars 74 forks source link

Switch metrics from tgo to go-metrics #222

Closed arnecls closed 6 years ago

arnecls commented 6 years ago

The purpose of this pull request

Exchange tgo.metrics with go-metrics to improve metrics and allow different metrics provider. Request as by issue #221

Checklist

[x] make test executed successfully
[ ] unit test provided
[ ] docs updated

coveralls commented 6 years ago

Coverage increased (+0.3%) to 71.509% when pulling 88bb71dae4089b63c3ebd4c13d2e60c7914a9982 on refactor/go-metrics into a5a3e696f1d80a0eaab34cf05193f37088886cf9 on master.

ppar commented 6 years ago

Other than the NewSubRegistry() nitpicking above, looks OK to me - however, I haven't worked closely with a lot of the code involved here.

arnecls commented 6 years ago

merged in order to move forward with 0.6