trivago / gollum

An n:m message multiplexer written in Go
http://gollum.readthedocs.org/en/latest/
Apache License 2.0
940 stars 74 forks source link

Delete failing errors_test.go #251

Closed M3t0r closed 5 years ago

M3t0r commented 5 years ago

The purpose of this pull request

The only test case in that file only tests if the constructor function exists and returns an error with a correctly formatted string. This format changed in 4ce38f3546eb88b7265acb8d02e2e8f37f5fc5eb but wasn't updated in the test. And everything besides the format is also tested by the go compiler at built time. We don't need a special test for that.

Checklist

arnecls commented 5 years ago

in 0.6.0 we still have this test, but I agree that it is somewhat pointless.

M3t0r commented 5 years ago

But it still passes in 0.6. Even though it's pointless :-)

arnecls commented 5 years ago

because I fixed the error message there :D