search

trivago / gollum

An n:m message multiplexer written in Go
http://gollum.readthedocs.org/en/latest/
Apache License 2.0
940 stars 74 forks source link

Windows build contains a Linux ELF executable #258

Closed mhewedy closed 5 years ago

mhewedy commented 5 years ago 
$ curl -L -k https://github.com/trivago/gollum/releases/download/v0.5.4/gollum-0.5.4-Windows_x64.zip -o gollum-0.5.4-Windows_x64.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   618    0   618    0     0    753      0 --:--:-- --:--:-- --:--:--   753
100 5968k  100 5968k    0     0   242k      0  0:00:24  0:00:24 --:--:--  328k

mhewedy@N16497 /c/temp
$ unzip gollum-0.5.4-Windows_x64.zip
Archive:  gollum-0.5.4-Windows_x64.zip
  inflating: gollum

mhewedy@N16497 /c/temp
$ file gollum
gollum: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), statically linked, stripped
arnecls commented 5 years ago

Found a problem in the makefile that caused this. Fixed in 0.5.x, will pick it into 0.6.0, too.

Here is a correct build of the current 0.5.x branch. gollum-0.5.4-3-ce72d99d-Windows_x64.zip

mhewedy commented 5 years ago

Thanks.