trivago / parallel-webpack

Builds multi-config webpack projects in parallel
BSD 3-Clause "New" or "Revised" License
1.48k stars 96 forks source link

Include webpack 5 as peer dependence #113

Closed eaglus closed 2 years ago

eaglus commented 3 years ago

Because of error while npm install project with webpack5

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! Found: webpack@5.24.4 npm ERR! node_modules/webpack npm ERR! dev webpack@"^5.24.4" from the root project npm ERR! peer webpack@">=4.6.0" from @loadable/webpack-plugin@5.14.2 npm ERR! node_modules/@loadable/webpack-plugin npm ERR! dev @loadable/webpack-plugin@"^5.14.2" from the root project npm ERR! 15 more (@webpack-cli/configtest, babel-loader, ...) npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer webpack@"^1.12.9 || ^2.2.0 || ^3.x || ^4.x" from parallel-webpack@2.6.0 npm ERR! node_modules/parallel-webpack npm ERR! dev parallel-webpack@"^2.6.0" from the root project

bin-umar commented 3 years ago

because of this, doesn't work in npm 7! Please merge it asap

eaglus commented 3 years ago

@trivagoUserSync @rjanjic @efegurkan please merge this mr, we need it to work with webpack5. i checked work of parallel-webpack with webpack5, it works without any problems

alverdal commented 2 years ago

Is this repo no longer maintained? Or can somebody please merge this PR to support webpack 5 ?

pago commented 2 years ago

It's probably unmaintained. Perhaps @byara could help to get one last release out and then sunset the repo?

byara commented 2 years ago

Hey @pago, I was about to publish but it seems the package is not under trivago org anymore and only you and @efegurkan used to have access. What I can do is to republish it under trivago namespace and also update readme etc.

efegurkan commented 2 years ago

I double checked my account, I don't have access to any organization through my npm. I would either contact them and/or republish as you said.

pago commented 2 years ago

It seems like @rjanjic has maintainer rights. He should be able to give you access as well.

byara commented 2 years ago

The package is published under trivago org name: https://www.npmjs.com/package/@trivago/parallel-webpack.